D8 Port of Adobe Analytics (SiteCatalyst) to D8

There are some comments https://www.drupal.org/node/2682257 that need to be addressed. I will create issues for them on the sandbox and we can work on those and any other bugs there.

@panshulk just curious if you are still actively working on this? Can/Should we keep working on this sandbox repo?

@kmoll Thanks for the reminder.

Yes, we're working on the pending issues. Will keep you posted.

Thanks :)

I have fixed all the coding standard issues.
Please review!

Many Thanks

@zeeshan_khan thank you for responding. I had put a patch on the issue #2682257: [D8]AdobeAnalytics that addressed some of these things that were committed here as well as some other updates based on the code review of the module. I will post some issues that I have found and am working on on the sandbox as well. We should try not to duplicate effort here. I need to help get this module to a stable version as I need it for some projects I am working on, so lets please communicate as to what is needed so we can divide the work. Can you please review that so we can commit it if it passes review and get the sandbox moved to an official project.

@zeeshan_khan as far as ADOBEANALYTICS_TOKEN_CACHE, this is not used anywhere in the module. If the use of it is yet to be implemented thats fine, if with the updates for D8 this is no longer needed, it should be removed.

@kmoll Thanks for the effort you're making to complete this sandbox project lets connect on skype I'll send my skype id to you in email.
I'll also review the patch and will ask @panshulk to apply it or better would be I'll ask him to grant you push access so that you can directly commit your work in the sandbox repo.

Hi @kmoll and @zeeshan_khan , apologies for replying late on this. Thanks a lot for your efforts of picking this up and speeding it up to promote this as a full project. @kmoll i have granted you with the push access so that you can directly commit your work after testing. Meanwhile i will also review the patch and provide the updates on the issue.
Thanks :)

Thanks @panshulk The patch I created in #2682257: [D8]AdobeAnalytics, doesn't apply any more with the updates that were recently committed. I am re-rolling the patch and will post it on that issue. Thank you for giving me commit access. I will still create patches and have them reviewed either by you, or another member of the community before committing.

I am actually going to post the patch here. I think since this is an issue on the project we can/should solve the issue here then report on #2682257: [D8]AdobeAnalytics once committed that it has been updated and we can request the project be reviewed again and made a proper project.

again, for any reviewers, there are still a few issues that we will need to fix, but the patch addresses all the code review feedback in #2682257: [D8]AdobeAnalytics.

Updated the patch to fix a function signature.

Thanks @kmoll, For your work.
I really like the touch ups and fixes you did in the patch specially change with $adobeanalytics_version that you have converted in settings form field and used it with config.

Reviewed:
https://www.drupal.org/node/2743377#comment-11818438
https://www.drupal.org/node/2700715#comment-11818427

Committed, thanks everyone!

Hoorray!!!!!

Thanks everyone for the hard work!

Keep Contributing :) :) :)