Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a side issue I noticed while looking at
#2700057: Ajax Flag is failing.
A little bug crept in
#2463365: Implement theming for flag link
if ($action === 'unflag') {
$render['#title'] = $flag->getUnflagShortText();
$render['#attributes']['#alt'] = $flag->getUnflagLongText();
}
else {
$render['#title'] = $flag->getFlagShortText();
$render['#attributes']['alt'] = $flag->getFlagLongText();
}
'#alt' is not correct
Comment | File | Size | Author |
---|---|---|---|
#2 | alt-2700383-2.patch | 563 bytes | martin107 |
|
Comments
Comment #2
martin107 CreditAttribution: martin107 commentedComment #4
socketwench CreditAttribution: socketwench at FFW commentedOoops. That's my fault.
Well spotted, Martin!
Comment #5
martin107 CreditAttribution: martin107 commentedAh no problems, I am eating a big plate of humble pie as my review missed it. :)
Comment #6
pheraph CreditAttribution: pheraph commentedUpdated from 8.x-4.x-dev (2016-04-03) to the latest dev-version which contains this fix. Afterwards I got a 500 when opening a node with the flag-links. The error log reads:
mod_fcgid: stderr: PHP Fatal error: Call to undefined method Drupal\\Core\\Entity\\Sql\\SqlContentEntityStorage::loadIsFlagged()
Reverting back to the previous version "fixed" it for me.
Comment #7
socketwench CreditAttribution: socketwench at FFW commented@pheraph, I doubt this change caused your SQL error, there's been a *lot* of commits in the last three days and many of them are incompatible with previous versions.
Given your error, I think this change probably is the cause: #2488564: [regression] load all flagging data on an entity when viewing it
Comment #8
socketwench CreditAttribution: socketwench at FFW commented