This is a side issue I noticed while looking at

#2700057: Ajax Flag is failing.

A little bug crept in

#2463365: Implement theming for flag link

    if ($action === 'unflag') {
      $render['#title'] = $flag->getUnflagShortText();
      $render['#attributes']['#alt'] = $flag->getUnflagLongText();
    }
    else {
      $render['#title'] = $flag->getFlagShortText();
      $render['#attributes']['alt'] = $flag->getFlagLongText();
    }

'#alt' is not correct

CommentFileSizeAuthor
#2 alt-2700383-2.patch563 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

Assigned: martin107 » Unassigned
Status: Active » Needs review
FileSize
563 bytes

  • socketwench committed ccf40db on 8.x-4.x authored by martin107
    Issue #2700383 by martin107: Fixed incorrect #alt in ActionLinkTypeBase.
    
socketwench’s picture

Status: Needs review » Fixed

Ooops. That's my fault.

Well spotted, Martin!

martin107’s picture

Ah no problems, I am eating a big plate of humble pie as my review missed it. :)

pheraph’s picture

Status: Fixed » Needs review

Updated from 8.x-4.x-dev (2016-04-03) to the latest dev-version which contains this fix. Afterwards I got a 500 when opening a node with the flag-links. The error log reads:

mod_fcgid: stderr: PHP Fatal error: Call to undefined method Drupal\\Core\\Entity\\Sql\\SqlContentEntityStorage::loadIsFlagged()

Reverting back to the previous version "fixed" it for me.

socketwench’s picture

@pheraph, I doubt this change caused your SQL error, there's been a *lot* of commits in the last three days and many of them are incompatible with previous versions.

Given your error, I think this change probably is the cause: #2488564: [regression] load all flagging data on an entity when viewing it

socketwench’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.