Note: For guidelines and instructions pages linked below, log in with user name / password: drupal/drupal.
Task for this issue
Edit the entire User Guide for the following copy editing guideline(s):
Avoid mentioning specific versions of Drupal, such as Drupal 7, Drupal 8, etc.
Instructions
See https://userguide_new-drupal.dev.devdrupal.org/guidelines/instructions.h... -- but skip the section on finding a task to do, since you have selected this one.
Checklist for this task
- Is a patch file provided?
- Is the edit for the provided guidelines complete and correct?
- Is the patch free from additional edits outside the scope of the provided guidelines?
- Is attribution provided? See https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines.htm...
Comment | File | Size | Author |
---|---|---|---|
#15 | 2699051-15.patch | 3.9 KB | metzlerd |
#10 | 2699051-10.patch | 6.05 KB | batigolix |
#5 | 2699051-5.patch | 6.38 KB | batigolix |
Comments
Comment #2
jhodgdonComment #3
jhodgdonI've now centralized instructions for the editing tasks. I'll go ahead and leave the instructions on these issues, but you can also go to
https://userguide_new-drupal.dev.devdrupal.org/guidelines/instructions.h...
(log in with drupal / drupal)
and follow the instructions there (probably more complete).
Comment #4
batigolixClaiming
Comment #5
batigolixHere's a patch.
I removed reference to D8 everywhere, except in external links, examples and comments
Comment #6
batigolixComment #7
ifrikThanks batigolix,
I think in some instances we need to keep the reference to Drupal 8 because it refers to some that specifically different to Drupal 7 (such as reference to composer, console or clean urls).
Also the guide is specifically for D8 so it should be the "Drupal 8 User guide"
I think we need to keep this here because the guide is specific to D8.
We should keep D8 here as well, because in D7 clean URLs are not required.
Keep D8 here as well, because console won't work with D7 afaik.
This could be reworded even further to "Content types can either ..."
This is also D8 specific.
Comment #8
jhodgdonActually, I think we can mostly not say 8 anywhere, except in the title of the overall guide (in the guide.txt file). I think we should only mention Drupal 8 specifically in cases where we are talking about the history of Drupal (hypothetically, because we do not have a topic about this in the Guide as it is now).
So, in comment #7...
Point 1 - agreed, let's keep the overall title as Drupal 8 User Guide.
Point 2/3/5 - disagree. I think we should not mention the number 8 in these spots. These will presumably also be true in 9, 10, ... maybe anyway.
Point 4 - Well, yes, we could remove mentions of Drupal there, but we could also do that in the other spots... and we have a separate issue for that.
So. Let's just revert the change to guide.txt and go with that.
Comment #9
ifrikComment #10
batigolixThanks ifrik & jhodgdon for reviewing. Here is a new patch.
One could argue that the version number should even be removed from the title of the guide, because in theory (but unlikely) someone could create a Drupal 7 version of the guide. And do we create a new project for D9?
Anyhow, I put the 8 back in the title ... Time for another review.
Comment #11
jhodgdonFor Drupal 9, I am assuming that we will just make a 9.x-0.x branch of the User Guide. We could also branch to 7.x if we wanted to.
So... We can leave a few references to 8.x around, such as in the title (and for that matter, the cover image). But the idea is to minimize them, so when we do move to 9.x, we will not have to update that in very many places.
Anyway, the patch looks good to me! Except that it doesn't apply any more, due to other commits that happened recently. Much of it failed, actually... Could someone reroll it please?
Also, after (partially) applying this patch, I used "grep" to find places that still had the number 8 in them. I came up with the following pages -- can you check and see if they need updates? [some may be false alarms]
- config-uninstall.txt (referring to Drush -- I think we should say "a compatible version of Drush" or something like that)
- security-update-core.txt [most likely due to the patch not applying, but check anyway please? Maybe needs an update about Drush?]
- understanding-themes.txt [patch apply problem I think?]
Thanks!
Comment #12
jhodgdonStandardizing issue summaries for the editing issues.
Comment #13
batigolixUnassigning in case someone else wants to take over.
Comment #14
metzlerd CreditAttribution: metzlerd as a volunteer commentedComment #15
metzlerd CreditAttribution: metzlerd as a volunteer commentedComment #17
eojthebraveLatest patch looks good to me. I've also run a couple of search/regex to make sure there are no missed instances of
Drupal\s?[\d]
and there aren't any that we need to worry about here.Thanks @metzlerd, and @batigolix and everyone else for the help getting this tidied up.