Problem/Motivation

While working with Drupal 8 I experienced, that the twig file, does not follow the Twig naming conventions we have in D8. You can find a summary at Template naming conventions. We should change it before more and more people start to adopt D8 and the Leaflet module.

Proposed resolution

Use a dash instead of underscore for the file template and change the hook_theme() implementation.

leaflet_map.html.twig -> leaflet-map.html.twig

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

szeidler created an issue. See original summary.

szeidler’s picture

Status: Active » Needs review
FileSize
1.84 KB

The attached patch is changing the name and theme implementation.

  • pvhee committed a3274e4 on 8.x-1.x authored by szeidler
    Issue #2699007 by szeidler: Twig template name should follow naming...
pvhee’s picture

Status: Needs review » Fixed

Makes sense, thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.