Use Entity Cache in Field Collection [#2698775]

Problem/Motivation

Follow-up to #1268620: Use Entity Cache in Field Collection

The current solution doesn't update hook_schema(). The way that og and fieldable_panels_panes works around this is by adding something to their hook_schema to list support for entitycache. Let's do the same here. This is particularly a problem for me where I'm trying to build a filtered db dump of the site using the data from drupal_get_complete_schema(), which isn't providing accurate details since cache_entity_field_collection_item isn't returned.

Proposed resolution

Follow the approach used by og & fpp.

Remaining tasks

Review time!

User interface changes

n/a

API changes

n/a

Data model changes

yes, adds some things to hook_schema that were already created by entity module.

Comment	File	Size	Author
#10	2698775-10.patch	1.77 KB	ilgnerfagundes
#10	7.x-1.x: PHP 7.2 & MySQL 5.5, D7 17 pass
#9	S0i48jo - Imgur.png	28.52 KB	ilgnerfagundes
#7	interdiff.txt	1.82 KB	joelpittet
#7	2698775-7-flush-cache.patch	1.78 KB	joelpittet
#7	7.x-1.x: PHP 7.2 & MySQL 5.5, D7 17 pass
#6	2698775-6-flush-cache.patch	425 bytes	joelpittet
#6	7.x-1.x: PHP 7.2 & MySQL 5.5, D7 run-tests.sh exception
#2	field_collection-use_entity_cache_in-2698775-2.patch	551 bytes	heddn
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 April 2016 at 21:33

heddn created an issue. See original summary.

Comment #2

heddn

English

Nicaragua

CreditAttribution: heddn at MTech, LLC, Forum One commented 1 April 2016 at 21:37

File	Size
field_collection-use_entity_cache_in-2698775-2.patch	551 bytes

Comment #3

heddn

English

Nicaragua

CreditAttribution: heddn at MTech, LLC, Forum One commented 1 April 2016 at 21:44

Issue summary:	View changes
Status:	Active	» Needs review

Comment #4

davide.taibi CreditAttribution: davide.taibi commented 31 March 2017 at 13:23

Is there any news on this issue?
We have a content type with several Fields Collections (a total or nearly 900 fields) that require nearly 90 seconds only to load.
Is there any safe workaround or patches I can apply to the content type to cache the generation of the page?

Comment #5

delacosta456 CreditAttribution: delacosta456 commented 7 September 2017 at 16:38

hi
hello .. yes please is there any update about this please

thanks

Comment #6

joelpittet

English

Vancouver

CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented 30 July 2020 at 23:27

File	Size
2698775-6-flush-cache.patch	425 bytes
7.x-1.x: PHP 7.2 & MySQL 5.5, D7 run-tests.sh exception

1 file was hidden/shown/deleted

File	Size
field_collection-use_entity_cache_in-2698775-2.patch	551 bytes

  if (module_exists('entitycache')) {
    $schema['cache_entity_field_collection_item'] = drupal_get_schema_unprocessed('system', 'cache');
    $schema['cache_entity_field_collection_item']['description'] = 'Cache table used to store field_collection_item entity records.';
  }

Maybe I can add to this to help out entity cache with this patch to clear it like og and fieldable_panels_panes does when cache is cleared.

Comment #7

joelpittet

English

Vancouver

CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented 31 July 2020 at 17:33

File	Size
2698775-7-flush-cache.patch	1.78 KB
7.x-1.x: PHP 7.2 & MySQL 5.5, D7 17 pass
interdiff.txt	1.82 KB

1 file was hidden/shown/deleted

File	Size
2698775-6-flush-cache.patch	425 bytes
7.x-1.x: PHP 7.2 & MySQL 5.5, D7 run-tests.sh exception

The difference between the others is that the creation of that table is not dependent on the entitycache module existing. Adding an extra cache table doesn't really need a module_exists check and makes things more complicated when it comes to which came first...

This is more in line with @heddn's original patch.

I fixed a double space in my patch too (thanks @jplana)