When I set in a field a taxonomy (with his bundle) and a content (with his bundle) only nodes are returning in the search result.

Actually it does work normally as a normal field but as a paragraph.

When is using this field as a paragraph the AJAX that changes the queries get missing and just get selected Content and change it to Taxonomy Term don't work. My thought could be the AJAX miss the ID when the Paragraph inject / include this field.

CommentFileSizeAuthor
#7 taxonomies_and_nodes-2698065-7.patch7.41 KBjibran
#7 interdiff.txt2.41 KBjibran
#6 taxonomies_and_nodes-2698065-6.patch6.33 KBjibran
#6 interdiff.txt2.79 KBjibran
#5 taxonomies_and_nodes-2698065-5.patch3.54 KBjibran
#5 interdiff.txt3.11 KBjibran
#2 2698065-2.patch2.85 KBkillua99
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

killua99 created an issue. See original summary.

killua99’s picture

killua99 CreditAttribution: killua99 commented
Status: Active » Needs review
FileSize
2698065-2.patch2.85 KB

Actually I found the issue.

Was all in the javascript on change attribute. The logic works well but the naming confection isn't modular or that dynamic tho

This is my first approach on how to solve this issue.

The selector is looking for a select name=something but it doesn't work with inline form like paragraphs where the field name will be paragraph[paragraph_entity][field_name] so from there it start failing.

I did a first thought on how to solve via class and not naming fields. Will be hard to know if any other module on the whild have differents names but class.

The module could build the class and made them more reliable than a field name.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Needs work

Have you tried this JS with mutli value field?

killua99’s picture

killua99 CreditAttribution: killua99 commented

Yes and it fails.

It was my first thoughts on how to solve the issue adding a class selector. Still it need to figure out the form_state and add the delta from somewhere.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: Taxonomies and Nodes don play nice with Paragraphs » DER widget doesn't work with Paragraphs
Status: Needs work » Needs review
Issue tags: +JavaScriptTest
FileSize
interdiff.txt3.11 KB
taxonomies_and_nodes-2698065-5.patch3.54 KB

How about this? Let me add some tests for this as well.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
FileSize
interdiff.txt2.79 KB
taxonomies_and_nodes-2698065-6.patch6.33 KB

Now with JS tests <3

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
FileSize
interdiff.txt2.41 KB
taxonomies_and_nodes-2698065-7.patch7.41 KB

Expanded test coverage a little and added some docs.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Plugin/Field/FieldWidget/DynamicEntityReferenceWidget.php
@@ -78,6 +79,7 @@ class DynamicEntityReferenceWidget extends EntityReferenceAutocompleteWidget {
+    $js_class = Html::cleanCssIdentifier("dynamic-entity-reference-{$items->getName()}[$delta][target_type]");

nice

  • jibran committed 13c856b on 8.x-1.x 
    Issue #2698065 by jibran, killua99, larowlan: DER widget doesn't work...

  • jibran committed e540348 on 8.x-1.x 
    Issue #2698065 by jibran, killua99, larowlan: DER widget doesn't work...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks @larowlan for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.