This kills a few theme functions and uses simple render arrays instead.

Also cleans up the CSS a bit and removes the weird span elements.

CommentFileSizeAuthor
#4 icon-theme-2695089-4-interdiff.txt1.8 KBberdir
#4 icon-theme-2695089-4.patch16.72 KBberdir
#2 icon-theme-2695089-2.patch15.72 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new icon-theme-2695089-2.patch15.72 KB

Status: Needs review » Needs work

The last submitted patch, 2: icon-theme-2695089-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new icon-theme-2695089-4.patch16.72 KB
new icon-theme-2695089-4-interdiff.txt1.8 KB

Fixed one bug and the destination now uses the absolute URL.

  • Berdir committed 374ee01 on 8.x-1.x 
    Issue #2695089 by Berdir: Convert icon theme functions to render arrays
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committing this so I can move forward with #2695153: Convert review form theme functions to twig which is based on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.