FILE: ...odules/contrib/password_policy/src/Tests/PasswordManualReset.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 24 | ERROR   | [ ] Visibility must be declared on method
    |         |     "testManualPasswordReset"
 32 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: 'administer permissions'
 57 | ERROR   | [ ] Visibility must be declared on method
    |         |     "testExcludeMyself"
 62 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: 'administer permissions'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...es/contrib/password_policy/src/Tests/PasswordPolicyInterface.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 29 | ERROR | [ ] Visibility must be declared on method
    |       |     "testOwnUserPasswords"
 71 | ERROR | [x] Functions must not contain multiple empty lines in
    |       |     a row; found 3 empty lines
 73 | ERROR | [ ] More than 2 empty lines are not allowed
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/contrib/password_policy/src/Tests/PasswordResetBehaviors.php
----------------------------------------------------------------------
FOUND 38 ERRORS AND 2 WARNINGS AFFECTING 20 LINES
----------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  35 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  36 | ERROR   | [x] Whitespace found at end of line
  42 | ERROR   | [ ] Visibility must be declared on method
     |         |     "testPasswordResetBehaviors"
  56 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  57 | ERROR   | [x] Functions must not contain multiple empty lines
     |         |     in a row; found 2 empty lines
  64 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
     |         |     found 6
  65 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
     |         |     found 6
  69 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, or question marks
  80 | ERROR   | [x] No space found before comment text; expected "//
     |         |     'roles[authenticated]' => 'authenticated'," but
     |         |     found "//'roles[authenticated]' =>
     |         |     'authenticated',"
  80 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, or question marks
  90 | ERROR   | [x] Expected 1 space between "'name'" and double
     |         |     arrow; 0 found
  90 | ERROR   | [x] Expected 1 space between double arrow and
     |         |     "'testuser1'"; 0 found
  90 | ERROR   | [x] Expected 1 space before "=>"; 0 found
  90 | ERROR   | [x] Expected 1 space after "=>"; 0 found
  99 | ERROR   | [x] Functions must not contain multiple empty lines
     |         |     in a row; found 2 empty lines
 120 | ERROR   | [x] Functions must not contain multiple empty lines
     |         |     in a row; found 2 empty lines
 126 | ERROR   | [x] Expected 1 space between "'name'" and double
     |         |     arrow; 0 found
 126 | ERROR   | [x] Expected 1 space between double arrow and
     |         |     "'testuser1'"; 0 found
 126 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 126 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 126 | ERROR   | [x] Expected 1 space between "'pass'" and double
     |         |     arrow; 0 found
 126 | ERROR   | [x] Expected 1 space between double arrow and
     |         |     "'pass'"; 0 found
 126 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 126 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 127 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 127 | ERROR   | [x] No space found before comment text; expected "//
     |         |     $this->drupalLogin($user2);" but found
     |         |     "//$this->drupalLogin($user2);"
 127 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, or question marks
 129 | ERROR   | [x] Concat operator must be surrounded by a single
     |         |     space
 131 | ERROR   | [x] Functions must not contain multiple empty lines
     |         |     in a row; found 2 empty lines
 148 | ERROR   | [x] Expected 1 space between "'name'" and double
     |         |     arrow; 0 found
 148 | ERROR   | [x] Expected 1 space between double arrow and
     |         |     "'testuser1'"; 0 found
 148 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 148 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 148 | ERROR   | [x] Expected 1 space between "'pass'" and double
     |         |     arrow; 0 found
 148 | ERROR   | [x] Expected 1 space between double arrow and
     |         |     "'pass'"; 0 found
 148 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 148 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 163 | ERROR   | [x] Functions must not contain multiple empty lines
     |         |     in a row; found 2 empty lines
 170 | ERROR   | [x] The closing brace for the class must have an
     |         |     empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 123ms; Memory: 7Mb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

Status: Active » Needs review
FileSize
7.15 KB
nerdstein’s picture

Assigned: markdorison » nerdstein

Reviewed and will be committing this weekend. Thank you for the cleanup!

nerdstein’s picture

New patch based on recent commits

  • nerdstein committed 86bed11 on 8.x-3.x authored by markdorison
    Issue #2694439 by markdorison, nerdstein: Clean up code style issues in...
nerdstein’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.