Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
After fixing all Emogrifier issues and using it properly, I believe that the Emogrifier dependency should be re-introduced in the 7.x-2.x branch.
The module isn't really usable if you want to send the order information in an email - inline styles will be ignored by some email clients, and there is no point in providing broken functionality.
I'll think about this a bit more, and then commit the changes.
If anyone has any comments, please let me know.
Thanks!
Comments
Comment #2
aramboyajyan CreditAttribution: aramboyajyan commentedNote: this would also stay consistent with what's written on the project page.
Comment #3
rooby CreditAttribution: rooby commentedSo far I have only used the 1.x branch (is the 2.x branch stable enough to use yet?) but I would plead that you don't make emogrifier a dependency this time around.
The reason being is that I use the mimemail module on all my sites and it provides the submodule mimemail_compress, which removes the need to also have the emogrifier module.
With almost 90000 installs I think that mimemail users need to be considered.
If there is emogrifier integration I think it should be optional.
Comment #4
aramboyajyan CreditAttribution: aramboyajyan commentedThanks for pointing that out Reuben; I'll have a look at it when I get some time. One possibility would be to allow both modules to be used. The usage of Emogrifier is anyway limited to one single function for processing the HTML, so we can easily have an alternative callback if the mimemail is installed instead.
Just for reference: this might require hook_requirements() in the .install file.
Will keep you posted.
Comment #5
rooby CreditAttribution: rooby commentedAwesome, thanks.
Comment #6
aramboyajyan CreditAttribution: aramboyajyan commentedJust tested this multiple times and it works perfectly. Integration with
mimemail_compress
is actually pretty easy.Updates will be up shortly on the
7.x-2.x-dev
branch.I didn't add a strict dependency for either of them, because the module still works, though with limited success across mail hosts.
I might also implement
hook_requirements()
to add some messages for administrators about Emogrifier and Mimail Compress modules.Thanks again for bringing this up.
Comment #8
aramboyajyan CreditAttribution: aramboyajyan commentedComment #9
aramboyajyan CreditAttribution: aramboyajyan commentedUpdating the title.