Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2600382: Come up with a simple access/permission system for Workspaces
Now that Workspaces have access control on themselves, can we leverage Workspaces to enhance access to entities within a workspace? Probably. :-)
From the previous issue, we want two* permissions:
bypass content access control in own workspace - Similar to the "bypass content access control" but specific to only the user's own workspaces. This will allow users to edit any content in own workspace. If the user does not have this permission, then regular content entity access rules would apply. That means a user could have wider permissions within a given workspace than they would otherwise.
bypass content access control in $id workspace - Same thing, but specific to a named workspace rather than a workspace the user own.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff-2693867.txt | 5.52 KB | Crell |
| #9 | 2693867-workspace-bypass.patch | 20.54 KB | Crell |
Comments
Comment #2
Crell CreditAttribution: Crell at Palantir.net for Acquia commentedComment #3
Crell CreditAttribution: Crell at Palantir.net for Acquia commentedHere's a kind of working patch. The code seems like it should be right, however, the test is still failing with a 404 on the second edit attempt. I'd expect a 200, or maybe a 403 if my code was wrong, but a 404 I do not understand.
Comment #4
timmillwoodAwesome work! Apart from the failing test it looks good to me.
I'm wondering about the wording of the permissions, all across the D8 UI "content" seems to mean "node", and we're on about bypassing more than just nodes, but using the word entit(y/ies) might bring more confusion to an end user.
Maybe
Bypass content entities access in own workspacewould work?Comment #5
Crell CreditAttribution: Crell at Palantir.net for Acquia commentedSure, I've changed the name to "content entity access" in the branch. No new patch yet until we get the tests sorted out. I could use help on that. :-(
Comment #6
timmillwood@crell - you forgot
hook_entity_create_access(), please review and commit if you're happy.Comment #7
timmillwoodAdding interdiff
Comment #9
Crell CreditAttribution: Crell at Palantir.net for Acquia commentedD'Oh! Thanks Tim. There were some issues merging Tim's branch and mine, but I've sorted those out. I also then added some additional tests, including negative tests, and everything seems to work correctly.
Attached patch is the final change, and the interdiff is my test additions. All tests pass for me locally so I have merged the resulting branch.