First, I must say this is a very helpful module while I using this I had an issue with the breadcrumb attached a screenshot for reference

CommentFileSizeAuthor
#8 fix_rdf_field_mapping_breadcrumbs-2693379-8.patch589 bytesAnonymous (not verified)
#2 rdfui-breadcrumb-issue-2693379-2-8.x.patch2.27 KBmimran
Screen Shot 2016-03-24 at 12.16.36 PM.png19.12 KBmimran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mimran created an issue. See original summary.

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
FileSize
rdfui-breadcrumb-issue-2693379-2-8.x.patch2.27 KB

Attached a patch

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Active » Needs review
Sachini’s picture

Sachini CreditAttribution: Sachini as a volunteer commented
Status: Needs review » Needs work

Hi mimran,
Thanks for posting the issue and the patch.
When applying the patch, I get the error

Undefined offset: 2 in Drupal\rdfui\Breadcrumb\RdfUiBreadcrumbBuilder->applies() (line 24 of modules/rdfui/src/Breadcrumb/RdfUiBreadcrumbBuilder.php).
Drupal\rdfui\Breadcrumb\RdfUiBreadcrumbBuilder->applies(Object) (Line: 78)
mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented

Hi Sachini,
i have checked the patch again with drupal 8.1.3 it worked fine for me in which version you checked?
Thanks

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Needs work » Needs review
Sachini’s picture

Sachini CreditAttribution: Sachini as a volunteer commented

I'm working on 8.1.3 too. Although the patch does modify the breadcrumbs as intended the error in #4 appears. To reproduce the error try clearing cache after the patch is applied.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commented
FileSize
fix_rdf_field_mapping_breadcrumbs-2693379-8.patch589 bytes

I've updated the patch to fix the `Undefined offset: 2` error. Also updated code for standards and readability.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs as a volunteer and commented
Status: Needs review » Closed (won't fix)

From my point of view, the breadcrumbs are just fine.
No need to change.

Thanks for the contribution, though.