Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
CI&T China team is upgrading this module in a hackathon event
Comment | File | Size | Author |
---|---|---|---|
#9 | updated_to_d8_from_7.x_2.x_dev-2693351-9.patch | 103.69 KB | aloneblood |
#6 | updated_to_d8-2693351-5.patch | 46.36 KB | jason-wang |
#3 | 0001-Port-the-login-one-time-module-to-D8-version.patch | 103.52 KB | jason-wang |
Comments
Comment #2
jason-wang CreditAttribution: jason-wang at CI&T commentedComment #3
jason-wang CreditAttribution: jason-wang at CI&T commentedUploading the patch, which started from a hackathon (co-worker: Jaguar, Michael Han, Steven Lin).
What have been done:
What's the next steps:
Comment #4
Maedi CreditAttribution: Maedi commentedPlease keep going and when it's ready we will create a D8 branch.
Comment #5
jason-wang CreditAttribution: jason-wang at CI&T commentedHi Maedi,
Here is the new patch with remaining tasks completed, which are:
could you please take a review when you have time, and let me know if anything more need to be done from my side.
Thanks,
Jason
Comment #6
jason-wang CreditAttribution: jason-wang at CI&T commentedSorry, forgot to upload the patch file, see attached "updated_to_d8-2693351-5.patch"
Comment #7
NitebreedPatch does not apply on the latest 7.x-2.x-dev Also, I'm not seeing an info.yml file and I'm missing the required class?
Comment #8
aloneblood CreditAttribution: aloneblood at CI&T commentedHi. This patch is created on 7.x-2.x-dev.
Comment #9
aloneblood CreditAttribution: aloneblood at CI&T commentedI'm sorry. The patch in #8 is error. I recreated a patch base on 7.x-2.x branch.
Comment #10
yechaozheng CreditAttribution: yechaozheng as a volunteer and commentedHi Maedi & Nitebreed,
Could you please help to check the new attached patch (#9) when you have time?
And please tell me what else you need if we want the D8 branch create.
Thanks,
Cato
Comment #11
yechaozheng CreditAttribution: yechaozheng as a volunteer and commentedComment #12
bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commentedHi Maedi,
Patch does not apply with the 7.x-2.x branch at my end. Please try to Create an Dev branch and port this module at your end if it works.
After that we will try to release an alfa version after fixing all minor issues.
Thanks,
Comment #13
manuel.adanAs an alternative, I can suggest implementing it using the email_confirmer module. I think most of the work will be completed with it and it would be easy to port this module to D8. If interested, I can help.
Comment #14
levmyshkinDrupal 8 module created by #9 patch:
https://github.com/levmyshkin/drupal-8-login-one-time
Comment #15
glass.dimly CreditAttribution: glass.dimly commentedThis github module should be released as an alpha branch, unless there are security issues in it, so that others can contribute.
Comment #16
bapi_22 CreditAttribution: bapi_22 at Globant commentedHi levmyshkin,
Can you please verify one more time if login one time button is visible on user account's page.
Then we can go for an alfa release.
Thanks
Comment #17
DuneBL@bapi_22, I have made a pull-request on the levmyshkin master branch with some fixes.
Whith those fixes, I confirm the button is displayed in the user account's page
For those who can't wait, here is the fixed branch I am talking about: https://github.com/dunebaud/drupal-8-login-one-time/tree/make-it-work
Comment #18
DuneBL@bapi_22 my PR has been accepted (so quick)
So please use: https://github.com/levmyshkin/drupal-8-login-one-time (As I have deleted my branch)
If you think it is a good idea, it can be pushed to drupal.ord
Comment #19
DuneBL@levmyshkin Have added another PR on Github to fix the option "Ignore User Password"
Comment #20
Chvojan CreditAttribution: Chvojan commentedHi, I'm trying use this module for Drupal 8. I can see a button at user account page. But the Action on user admin page is missing. I found "Send one-time login link to the selected users" in code and thats what I need. There is $options = login_one_time_path_options(); but this function is missing. Can you please help me. Am I doing something wrong?
Comment #21
JasonLuttrell+1. This works great in D7, really need this for D8. Thanks!