Problem/Motivation

There is no composer.json file found in module. Please see https://www.drupal.org/node/2514612

Proposed resolution

Add the composer.json file.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2692637-2.patch354 bytessmk-ka
#2 2692637-1.patch700 bytesrakesh.gectcr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Active » Needs review
FileSize
2692637-1.patch700 bytes
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo as a volunteer commented
Status: Needs review » Fixed

Committed and pushed to 8.x-1.x, thank you!

smk-ka’s picture

smk-ka CreditAttribution: smk-ka commented
Status: Fixed » Needs review
FileSize
2692637-2.patch354 bytes

Please don't add drupal/drupal as a required dependency, as it breaks composer when using the drupal/core package as replacement.

  • legolasbo authored 9095bbd on 8.x-1.x 
    Issue #2692637 by smk-ka, legolasbo: Add composer.json file  to module
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo as a volunteer commented

Thanks for pointing this out smk-ka. I changed the dependency to drupal/core as drupal/drupal replaces that package. This way the module at least requires drupal/core but won't screw with people using the drupal/drupal package.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo as a volunteer commented
Status: Needs review » Fixed
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented

I think we didnt add that on the first patch. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.