Hi Darrell,
In January, the company I work for developed a custom module quite similar to ip_path_access.

About two weeks ago, we were about to start enhancements with the intent to contribute the module on drupal.org. Then, while researching module name options, I stumbled upon ip_path_access.

There are three features of our module that are not in ip_path_access, if I am not mistaken:

  1. Support for the * wildcard
  2. Ability to enter multiple, comma separated IP ranges to associate with a single path.
  3. Ability to set a custom path redirect on access denial.

Otherwise, enhancements we planned on doing include:

  1. Text field to input a rule name, i.e. a description of the IP filter rule
  2. Text area field to accept multi-line path entries related to its rule (to replace our current comma separated list methodology)
  3. Text area field to accept multi-line IP range entries related to its rule

Rather than contribute a redundant module, we would prefer to contribute to ip_path_access. Please let me know if this is of interest.

Comments

mikebrooks created an issue. See original summary.

mikebrooks’s picture

Issue summary: View changes
darrell_ulm’s picture

Hi @mikebrooks, after thinking about:

Rather than contribute a redundant module, we would prefer to contribute to ip_path_access. Please let me know if this is of interest.

Yes, this is of interest.

There are three features of our module that are not in ip_path_access, if I am not mistaken:

Support for the * wildcard
Ability to enter multiple, comma separated IP ranges to associate with a single path.
Ability to set a custom path redirect on access denial.

As long as we make sure code that does this is not based on a licence that the licence used w/ Drupal is not compatible with. There is an IP range php code snippet out there that may not have a compatible licence. Given that, these sounds like good enhancements.

Otherwise, enhancements we planned on doing include:

Text field to input a rule name, i.e. a description of the IP filter rule
Text area field to accept multi-line path entries related to its rule (to replace our current comma separated list methodology)
Text area field to accept multi-line IP range entries related to its rule

These also sound like good enhancements.

Thank you.

mikebrooks’s picture

Hi @darrell_ulm,

Thanks for the positive follow up. I will review with my team and determine priorities for patches. We can add a new issue for each enhancement. If we hit roadblocks, or could use help to move issue(s) along, we will post to the issue(s) accordingly.

Stay tuned.

darrell_ulm’s picture

Thanks for the feedback @mikebrooks

alarez’s picture

Hi,

First of all, let me thank you for this module.
The mentioned enhancements would be awesome.

Can I suggest including an option to let Drupal handle access denied as the default 403 configured site wide ?

Thank you!

mikebrooks’s picture

Hi alarez,

I have added your request to the issue queue - https://www.drupal.org/node/2727997, but have taken it a step further by recommending that the access denied redirect be configurable.

Please review the issue and add a comment to indicate whether or not the issue description matches your objective.

Thanks - mikebrooks

alarez’s picture

Hi mikebrooks,

Both use cases are exactly what I was looking for.

Thank you so much. -alarez

darrell_ulm’s picture

I think others may have mentioned this, but an edit option for an entry would be nice.

mikebrooks’s picture

@ darrell_ulm,

I have added issue https://www.drupal.org/node/2735481 relative to #9.

rmambrose’s picture

@mikebrooks,

We have a use case for wildcard support. Wondering if you have any update on this, or if it's something we could contribute resources toward.

Thanks! - rmambrose