Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi Darrell,
In January, the company I work for developed a custom module quite similar to ip_path_access.
About two weeks ago, we were about to start enhancements with the intent to contribute the module on drupal.org. Then, while researching module name options, I stumbled upon ip_path_access.
There are three features of our module that are not in ip_path_access, if I am not mistaken:
- Support for the * wildcard
- Ability to enter multiple, comma separated IP ranges to associate with a single path.
- Ability to set a custom path redirect on access denial.
Otherwise, enhancements we planned on doing include:
- Text field to input a rule name, i.e. a description of the IP filter rule
- Text area field to accept multi-line path entries related to its rule (to replace our current comma separated list methodology)
- Text area field to accept multi-line IP range entries related to its rule
Rather than contribute a redundant module, we would prefer to contribute to ip_path_access. Please let me know if this is of interest.
Comments
Comment #2
mikebrooks CreditAttribution: mikebrooks as a volunteer commentedComment #3
darrell_ulm CreditAttribution: darrell_ulm as a volunteer commentedHi @mikebrooks, after thinking about:
Yes, this is of interest.
As long as we make sure code that does this is not based on a licence that the licence used w/ Drupal is not compatible with. There is an IP range php code snippet out there that may not have a compatible licence. Given that, these sounds like good enhancements.
These also sound like good enhancements.
Thank you.
Comment #4
mikebrooks CreditAttribution: mikebrooks at SNP Technologies, Inc. commentedHi @darrell_ulm,
Thanks for the positive follow up. I will review with my team and determine priorities for patches. We can add a new issue for each enhancement. If we hit roadblocks, or could use help to move issue(s) along, we will post to the issue(s) accordingly.
Stay tuned.
Comment #5
darrell_ulm CreditAttribution: darrell_ulm as a volunteer commentedThanks for the feedback @mikebrooks
Comment #6
alarez CreditAttribution: alarez at ParallelDevs commentedHi,
First of all, let me thank you for this module.
The mentioned enhancements would be awesome.
Can I suggest including an option to let Drupal handle access denied as the default 403 configured site wide ?
Thank you!
Comment #7
mikebrooks CreditAttribution: mikebrooks at SNP Technologies, Inc. commentedHi alarez,
I have added your request to the issue queue - https://www.drupal.org/node/2727997, but have taken it a step further by recommending that the access denied redirect be configurable.
Please review the issue and add a comment to indicate whether or not the issue description matches your objective.
Thanks - mikebrooks
Comment #8
alarez CreditAttribution: alarez at ParallelDevs commentedHi mikebrooks,
Both use cases are exactly what I was looking for.
Thank you so much. -alarez
Comment #9
darrell_ulm CreditAttribution: darrell_ulm as a volunteer commentedI think others may have mentioned this, but an edit option for an entry would be nice.
Comment #10
mikebrooks CreditAttribution: mikebrooks at SNP Technologies, Inc. commented@ darrell_ulm,
I have added issue https://www.drupal.org/node/2735481 relative to #9.
Comment #11
rmambrose CreditAttribution: rmambrose commented@mikebrooks,
We have a use case for wildcard support. Wondering if you have any update on this, or if it's something we could contribute resources toward.
Thanks! - rmambrose