Remove unused imports and unnessary fully qualified name in code base.

CommentFileSizeAuthor
#8 interdiff-2691253-5-8.txt566 bytesheykarthikwithu
#8 2691253-8.patch1.25 KBheykarthikwithu
#5 interdiff-2691253-2-5.txt760 bytesheykarthikwithu
#5 2691253-5.patch1.42 KBheykarthikwithu
#2 2691253-2.patch1.17 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
FileSize
2691253-2.patch1.17 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Needs work

Looks great, just needs a bit of work while you on that

+++ b/src/DefaultContentServiceProvider.php
@@ -7,9 +7,12 @@
+use Drupal\Core\DependencyInjection\ContainerBuilder;
 
-  public function alter(\Drupal\Core\DependencyInjection\ContainerBuilder $container) {
+class DefaultContentServiceProvider extends ServiceProviderBase {

Please add a docs block for the class, while you touch that

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: Unassigned » heykarthikwithu
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
FileSize
2691253-5.patch1.42 KB
interdiff-2691253-2-5.txt760 bytes

Changes as per #3

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
+++ b/src/DefaultContentServiceProvider.php
@@ -10,8 +10,17 @@
+   * Modifies existing service definitions.
+   *
+   * @param \Drupal\Core\DependencyInjection\ContainerBuilder $container
+   *   The ContainerBuilder whose service definitions can be altered.

that should be just {@inheritdoc}
cos defined and documented in \Drupal\Core\DependencyInjection\ServiceModifierInterface::alter()

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: Unassigned » heykarthikwithu
Status: Needs review » Needs work
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
FileSize
2691253-8.patch1.25 KB
interdiff-2691253-5-8.txt566 bytes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Thanx! great, to be commited soon

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

+1

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.