Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Add at least comments for all function declarations; other than that, there might be some additional comments necessary that will make contributions easier.
Will do this later today.
Comments
Comment #2
aramboyajyan CreditAttribution: aramboyajyan commentedComment #3
aramboyajyan CreditAttribution: aramboyajyan commentedRules code should also be moved to
commerce_invoice_receipt.module. This might need to be a few separate commits, but I'll reference this issue in all of them.Comment #4
aramboyajyan CreditAttribution: aramboyajyan commentedMove out the mailsystem implementation from the .admin.inc file, it makes no sense to put it there because it is NOT part of the administrative logic.
It can either be moved to the .module file, or a completely separate file.
Comment #5
aramboyajyan CreditAttribution: aramboyajyan commentedAfter thinking a bit, I will do this for the v2 branch instead, no sense to work simultaneously on both.
Comment #6
aramboyajyan CreditAttribution: aramboyajyan commentedUpdating the title. Later today the commits related to these tasks will be committed, and will reference this issue.
Comment #10
aramboyajyan CreditAttribution: aramboyajyan commentedStatus. This is fixed for the most part. Misc minor fixes will be committed separately now.