Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
If I try to map to an integer field, the following error is thrown:
Recoverable fatal error: Argument 5 passed to number_feeds_set_target() must be of the type array, boolean given.
Patch will follow.
Comment | File | Size | Author |
---|---|---|---|
#19 | feeds_xls-n2689865-19.patch | 997 bytes | DamienMcKenna |
#7 | feeds_xls-proper_target_mapping-2689865-7.patch | 2.39 KB | PascalAnimateur |
#4 | feeds_xls-mapinteger-2689865-4-7.x.patch | 417 bytes | RonanLK |
#2 | feeds_xls-mapinteger-2689865.patch | 444 bytes | dready2011 |
Comments
Comment #2
dready2011 CreditAttribution: dready2011 commentedComment #3
rosemaryreilmanHad similar issue not only with integer but also with date and text fields mapping. Applied same patch. Seems to have fixed the issue for me and allow import.
Comment #4
RonanLK CreditAttribution: RonanLK commenteddready2011’s patch fixed the fatal error for me, but integer fields were not imported.
Here is another patch that sends 'und' as the language.
Comment #5
Pierrere CreditAttribution: Pierrere as a volunteer commentedI can confirm this bug. Importing xls files was functional before and now stopped working.
The patch in #4 by ronan.leroy works and produces clean data on import.
Comment #6
PascalAnimateur CreditAttribution: PascalAnimateur commentedIt seems feeds_xls changes the callback for all targets, even on feeds not using the XLS parser.
This is caused by the
feeds_xls_feeds_processor_targets_alter
function ... this breaks other importers!!Comment #7
PascalAnimateur CreditAttribution: PascalAnimateur commentedThe callback signature for
*_feeds_set_target_*
has changed in feeds 7.x-2.x-dev to include a mapping argument... see number_feeds_set_target for an example.Here's a patch to fix that in feeds_xls. .. but still the processor target altering should not affect importers not using feeds_xls!
Comment #8
tijsdeboeckThanks for patch #7, it works perfectly!
Comment #9
rosemaryreilmanThanks for #7.
Comment #10
maxplus CreditAttribution: maxplus commentedThanks,
#7 worked for me!
Comment #11
PolThanks, #7 worked for me too.
Comment #12
dks786 CreditAttribution: dks786 commentednumber_feeds_set_target($source, $entity, $target, $value, array());
It removed my error,
But not importing feed (xls) value to my drupal field(checkbox field)
Comment #13
shi99 CreditAttribution: shi99 commentedPatch in #7 worked for me,
My boolean checkbox correctly gets the value set.
Thanks
Comment #14
mackpipe1 CreditAttribution: mackpipe1 commentedExcellent patch solution # 7, I only need a single error to correct, and it is the loading of data type Date, since it fails to load when there is a field of type date., Someone could help me to know That it lacks this process to be totally perfect
Comment #15
zterry95 CreditAttribution: zterry95 commentedconfirm #7 patch works for me.
Comment #16
cmseasy CreditAttribution: cmseasy commentedUsefull feature, using patch #5 on a production site for more then a year with success.
Please commit.
Comment #17
skylord CreditAttribution: skylord commentedSeems major as actually module is unusable without it on latest Feeds with different hook_feeds_set_target_* signature.
Comment #18
junaidpv#7 worked
Comment #19
DamienMcKennaI recommend using #2651420: Remove processors for list, numeric fields, which removes feeds_xls_feeds_set_target_list_text() and feeds_xls_feeds_set_target_numeric(), leaving only one function to fix.
Comment #20
DamienMcKennaChanging the issue title to make it more clear what the issue is.