As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 374 problems (374 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#2 faqeslinterror-2.patch25.8 KBNeelanjana Das
output.txt35.58 KBNeelanjana Das
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neelanjana Das created an issue. See original summary.

Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
FileSize
faqeslinterror-2.patch25.8 KB

The code is cleaned up in this patch.

sumitmadan’s picture

sumitmadan CreditAttribution: sumitmadan at QED42 commented
Status: Active » Needs review

Moving it to needs review.

Status: Needs review » Needs work

The last submitted patch, 2: faqeslinterror-2.patch, failed testing.

sumitmadan’s picture

sumitmadan CreditAttribution: sumitmadan at QED42 commented
Status: Needs work » Fixed

Thanks Neelanjana,

I have committed it to the 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.