[D7] Commerce GPG Checkout

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxutiks2678792git

I'm a robot and this is an automated message from Project Applications Scraper.

paraview.sh complains about 1 formatting issue, otherwise looks good!

Did a quick manual review, function names should be in english to be more understable:
gpg_checkout_paiement_typeshould be gpg_checkout_payment_type
etc.

And you are mixing CamelCaps, CAPS, lowercase etc, is this because of the payment solution GPG? And why do you you shorten the email address? Email adresses could be up to 254 chars long.

    'NumSite' => $settings['num_site'],
    'Password' => md5($settings['password']),
    'orderID' => $order->order_id,
    'EMAIL'   => drupal_substr($order->mail, 0, 64),
    'CustLastName' => $address_value['last_name'],
    'CustFirstName' => $address_value['first_name'],
    'CustAddress' => $address_value['thoroughfare'] . ' ' . $address_value['premise'],
    'CustZIP' => $address_value['postal_code'],
    'CustCity' => $address_value['locality'],
    'CustCountry' => $address_value['country'],
    'CustTel' => $order_wrapper->commerce_customer_billing->field_phone->value(),
    'Langue' => '',
    'Amount' => $total['amount'],
    'Currency' => $settings['currency_code'],
    'PayementType' => (int) $settings['paiement_type'],
    'orderProducts' => $order_description,
    'vad' => $settings['vad'],
    'Terminal' => $settings['terminal'],

I am little bit confused what is going on in the function gpg_checkout_process_notification, as an example, why do you save the whole $_POST in a variable?

And you should not add HTML in a watchdog log.

In function gpg_checkout_url you are settings hardcoded URLs for prod and preprod, why? Could they not be changed by GPG later on?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.