Problem/Motivation

The proposed WYSIWYG patch #2686171: WYSIWYG Integration calls renderThumbnail to trigger a download without needing the rendered thumbnail. This method should potentially be made public to prevent this.

Proposed resolution

Make it public and potentially add it to the interface.

Remaining tasks

Decide and patch.

User interface changes

None.

API changes

Possible API break, but not for people extending the base plugin.

Data model changes

None.

CommentFileSizeAuthor
#9 2687077-public-download-thumbnail-9.patch4.65 KBSam152
#3 2687077-public-download-thumbnail.patch4.26 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Title: Consider making 'downloadThumbnail' a public method on ProverBase to account for WYSIWYG usage. » Consider making 'downloadThumbnail' a public method on ProviderBase to account for WYSIWYG usage.
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review
FileSize
2687077-public-download-thumbnail.patch4.26 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2687077-public-download-thumbnail.patch, failed testing.

The last submitted patch, 3: 2687077-public-download-thumbnail.patch, failed testing.

The last submitted patch, 3: 2687077-public-download-thumbnail.patch, failed testing.

The last submitted patch, 3: 2687077-public-download-thumbnail.patch, failed testing.

The last submitted patch, 3: 2687077-public-download-thumbnail.patch, failed testing.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs work » Needs review
FileSize
2687077-public-download-thumbnail-9.patch4.65 KB

Reroll.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

This removes two @todos from the code base. It's on the provider base so I don't think it's at all disruptive. It adds a bit more flexibility, so I think it's worth the BC break.

  • Sam152 committed cd3f98b on 8.x-1.x 
    Issue #2687077 by Sam152: Consider making 'downloadThumbnail' a public...
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.