Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marthinal created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, mailsystem_dependency.patch, failed testing.

wellme’s picture

eugene.ilyin’s picture

@wellme, your patch contains an extra info.
I have prepared correct patch

eugene.ilyin’s picture

Status: Needs work » Needs review

The last submitted patch, 3: swiftmailer-2686997-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: swiftmailer-dependencies-2686997-4.D8.patch, failed testing.

Bart Vanhoutte’s picture

Status: Needs work » Needs review
FileSize
347 bytes

Might as well add support for installing SwiftMailer through Composer using Drupal Packagist.

Bart Vanhoutte’s picture

The last submitted patch, 9: 2686997-switfmailer_mailsystem_dependency-9.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2686997-switfmailer_mailsystem_dependency-9.patch, failed testing.

webflo’s picture

Status: Needs work » Needs review
FileSize
867 bytes

I makes sense to add mailsystem as a dependency, it makes it much easier to configure the module because core does not provide a UI for its mail settings and it provides an option to use a specific theme for every email. Which is important for swiftmailer since twig uses templates for all emails.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

We use mailsystem in all our projects and recommend to use it when using simplenews, so +1.

I see you didn't add the composer dependency, I personally don't care, but people have very different opinions about that.

webflo’s picture

I think composer is for external dependencies. And the Packagist implementation will handle it automatically.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 2686997-12.patch, failed testing.

webflo’s picture

Status: Needs work » Needs review
FileSize
2.19 KB

Status: Needs review » Needs work

The last submitted patch, 16: 2686997-16.patch, failed testing.

webflo’s picture

Status: Needs work » Needs review
FileSize
2.52 KB

Status: Needs review » Needs work

The last submitted patch, 18: 2686997-18.patch, failed testing.

webflo’s picture

Status: Needs work » Needs review
FileSize
2.55 KB

Status: Needs review » Needs work

The last submitted patch, 20: 2686997-20.patch, failed testing.

  • webflo committed ba2e984 on 8.x-1.x
    Issue #2686997: Add dependence on Mail System
    
webflo’s picture

Status: Needs work » Fixed

Released 8.x-1.0-alpha2 with the new dependency. This should fix the issues with Drupal CI. Thanks all!

  • webflo committed 142fcdf on 8.x-1.x
    Issue #2686997: Fix test discovery
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.