Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We should add mailsystem as a dependency.
Comment | File | Size | Author |
---|---|---|---|
#20 | 2686997-20.patch | 2.55 KB | webflo |
| |||
#18 | 2686997-18.patch | 2.52 KB | webflo |
| |||
#16 | 2686997-16.patch | 2.19 KB | webflo |
| |||
#12 | 2686997-12.patch | 867 bytes | webflo |
| |||
#9 | 2686997-switfmailer_mailsystem_dependency-9.patch | 628 bytes | Bart Vanhoutte |
|
Comments
Comment #3
wellme CreditAttribution: wellme at Zyxware Technologies commentedComment #4
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented@wellme, your patch contains an extra info.
I have prepared correct patch
Comment #5
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedComment #8
Bart Vanhoutte CreditAttribution: Bart Vanhoutte at Duo commentedMight as well add support for installing SwiftMailer through Composer using Drupal Packagist.
Comment #9
Bart Vanhoutte CreditAttribution: Bart Vanhoutte at Duo commented#5 + #8 in one patch.
Comment #12
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedI makes sense to add mailsystem as a dependency, it makes it much easier to configure the module because core does not provide a UI for its mail settings and it provides an option to use a specific theme for every email. Which is important for swiftmailer since twig uses templates for all emails.
Comment #13
BerdirWe use mailsystem in all our projects and recommend to use it when using simplenews, so +1.
I see you didn't add the composer dependency, I personally don't care, but people have very different opinions about that.
Comment #14
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedI think composer is for external dependencies. And the Packagist implementation will handle it automatically.
Comment #16
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #18
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #20
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #23
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedReleased 8.x-1.0-alpha2 with the new dependency. This should fix the issues with Drupal CI. Thanks all!