Order product setDescription t() missing.

CommentFileSizeAuthor
#7 orderproduct-2686989-7.patch2.34 KBPurnachandra Rao V
#4 ubercart_orderproduct.patch2.34 KBTR
ubercart_orderproduct.patch2.34 KBPurnachandra Rao V
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Purnachandra Rao V created an issue. See original summary.

Purnachandra Rao V’s picture

Purnachandra Rao V CreditAttribution: Purnachandra Rao V as a volunteer and at Melity commented
Status: Active » Needs review
TR’s picture

TR CreditAttribution: TR commented
Version: 8.x-4.0-alpha4 » 8.x-4.x-dev

Core Drupal has gone back and forth, first requiring t() in D7 for schema descriptions, then not allowing it, then requiring it in D8, then not allowing it, and now it seems the current fashion is to require t() again. Thanks for the patch, let's see what the testbot has to say.

TR’s picture

TR CreditAttribution: TR commented
FileSize
ubercart_orderproduct.patch2.34 KB

Need to upload this again with the issue at 8.x-4.x-dev so the testbot will test it.

Status: Needs review » Needs work

The last submitted patch, 4: ubercart_orderproduct.patch, failed testing.

TR’s picture

TR CreditAttribution: TR commented

Your patch is missing a ')' on the quantity description, which is why the testbot failed. Can you fix that and upload it again?

Purnachandra Rao V’s picture

Purnachandra Rao V CreditAttribution: Purnachandra Rao V as a volunteer and at Melity commented
FileSize
orderproduct-2686989-7.patch2.34 KB

Please find attached updated patch.

Purnachandra Rao V’s picture

Purnachandra Rao V CreditAttribution: Purnachandra Rao V as a volunteer and at Melity commented
Status: Needs work » Needs review
TR’s picture

TR CreditAttribution: TR commented
Status: Needs review » Fixed

Committed. Thanks.

  • TR committed 133ddb5 on 8.x-4.x authored by Purnachandra Rao V 
    Issue #2686989 by Purnachandra Rao V: Order product setDescription t()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.