Problem/Motivation

The proposal to relax the @file standard for autoloaded files ie classes, traits and interfaces is approved (see #2304909: Relax requirement for @file when using OO Class or Interface per file) and the Coder already introduced rules for checking the codebase (see #2665744: @file is not required for classes, interfaces and traits).

While Drupal core is waiting for 8.1.0-RC1 to cleanup, there's no reason not to do that for this module which is still in alpha.

Proposed resolution

Remove no longer needed @file docblocks from the codebase.

Remaining tasks

Write patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

Status: Active » Needs review
FileSize
13.59 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2686839-1.patch, failed testing.

The last submitted patch, 2: 2686839-1.patch, failed testing.

rakesh.gectcr’s picture

Status: Needs work » Needs review
FileSize
13.59 KB
naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • mglaman committed 78abd76 on 8.x-1.x authored by rakesh.gectcr
    Issue #2686839 by rakesh.gectcr: @file is not required for classes,...
mglaman’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

neerajsingh’s picture

Status: Closed (fixed) » Needs review
Issue tags: +Coding standards
FileSize
544 bytes

There was a file missed out('/src/Plugin/EntityReferenceSelection/ProfileSelection.php')... Adding the patch here..

naveenvalecha’s picture

Assigned: rakesh.gectcr » Unassigned
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Let's do it

  • mglaman committed 7682c24 on 8.x-1.x authored by neerajsingh
    Issue #2686839 by rakesh.gectcr, neerajsingh, mglaman: @file is not...
mglaman’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.