User Interface spellings on labels [#2686837]

Some spelling issues on configuration page for this module. Will submit patch shortly

Comment	File	Size	Author
#8	2686837-spell-check.patch	1.46 KB	rajdeep0826
#2	scrolltotop-userinterface-1135412-2-8.x-0.x-dev.patch	1.46 KB	marksward

Issue fork scroll_to_top-2686837

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2686837-user-interface-spellings changes, plain diff MR !4
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 March 2016 at 09:27

marksward created an issue. See original summary.

Comment #2

marksward CreditAttribution: marksward commented 14 March 2016 at 09:39

Status:

Active

» Needs review

File	Size
scrolltotop-userinterface-1135412-2-8.x-0.x-dev.patch	1.46 KB

Patch attached. First code patch submitted to Drupal, please advise if inappropriate or issues. thanks

Comment #3

marksward CreditAttribution: marksward commented 14 March 2016 at 09:40

Assigned:

marksward

» Unassigned

Comment #4

tarekdj CreditAttribution: tarekdj as a volunteer commented 14 March 2016 at 11:10

Status:

Needs review

» Needs work

Thanks marksward!
Your patch looks good but needs some clean up. No big deal!

+++ b/src/Form/ScrollToTopForm.php
@@ -65,13 +65,13 @@ class ScrollToTopForm extends ConfigFormBase {
-      '#description' => $this->t('label displayed in scroll to top link, default "Back to top".'),
+      '#description' => $this->t('Label displayed in scroll to top link, default "Back to top".'),

I don't see the reason of this.

+++ b/src/Form/ScrollToTopForm.php
@@ -102,7 +102,7 @@ class ScrollToTopForm extends ConfigFormBase {
-      '#description' => $this->t('Enable scroll to top button on administartion theme.'),
+      '#description' => $this->t('Enable scroll to top button on administration theme.'),

Same as 1.

Comment #5

marksward CreditAttribution: marksward commented 14 March 2016 at 19:04

thanks tarekdj First one is change of 'label' to 'Label' and second is change of 'administartion' to 'administration' hope that clears it up. If that's not what you mean please let me know.
thanks