Problem/Motivation

Drupal\fapi_example\Form\VerticalTabsDemo currently has a @todo regarding #2541252: Replace the .region-content ul/ol selector with text-formatted to refactor code + fix visual bugs

Read about its justification here: #2102659-79: Add new Form API example module for Drupal 8

Proposed resolution

  • Verify that vertical tabs render properly.
  • Remove the @todo.

Remaining tasks

User interface changes

API changes

Data model changes

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Update the patch to incorporate feedback from reviews (include an interdiff) Instructions
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

CommentFileSizeAuthor
#3 remove-todo-2686579-3.patch598 bytesPalashvijay4O
#3 Screen Shot 2016-03-28 at 11.30.12 PM.png49.03 KBPalashvijay4O
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Parent issue: » #2102659: Add new Form API example module for Drupal 8
Related issues: -#2102659: Add new Form API example module for Drupal 8
Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented
Status: Active » Needs review
FileSize
Screen Shot 2016-03-28 at 11.30.12 PM.png49.03 KB
remove-todo-2686579-3.patch598 bytes

Hi Mile... I tested and verified that the module is rendering verticaltabs properly. I am attaching a screenshot and a patch which I have created by removing @TODO.

Status: Needs review » Needs work

The last submitted patch, 3: remove-todo-2686579-3.patch, failed testing.

Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented
Status: Needs work » Needs review
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

The testbot is automatically testing against Drupal 8.2, but we're targeting 8.0. So I added another test with that version.

  • Mile23 committed 9cb3ad3 on 8.x-1.x authored by Palashvijay4O 
    Issue #2686579 by Palashvijay4O: @todo in Drupal\fapi_example\Form\...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue summary: View changes
Status: Needs review » Fixed

Nice, thanks.

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.