sms_receipt() is currently mostly unused. Only the hook is used on sms_track module. After the completion of #2542790: Implement API for delivery reports for SMS Gateways, the delivery reports API would be available for use.

CommentFileSizeAuthor
#8 2686459-8.patch5.16 KBalmaudoh
#3 2686459-3.patch3.81 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Issue tags: -beta target +beta blocker

Cleaning up beta tags.

This issue should be completed before beta, since it represents a API removal/change.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
FileSize
2686459-3.patch3.81 KB

Patch removes the sms_receipt() and replaces with sms_delivery_report hook.

https://github.com/dpi/smsframework/pull/36/files

Status: Needs review » Needs work

The last submitted patch, 3: 2686459-3.patch, failed testing.

The last submitted patch, 3: 2686459-3.patch, failed testing.

The last submitted patch, 3: 2686459-3.patch, failed testing.

The last submitted patch, 3: 2686459-3.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
2686459-8.patch5.16 KB

Forgot to delete the interface declaration

https://github.com/dpi/smsframework/pull/36/files

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

Just the hook doc nits need to be addressed.

Then its RTBC :)

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

Just the hook doc nits need to be addressed.

These were addressed when sms_track was removed. Can we say this is RTBC then?

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

Go nuts :)

  • almaudoh committed e7864f7 on 8.x-1.x 
    Issue #2686459 by almaudoh: Remove sms_receipt() and replace with...
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Fixed

Pushed to 8.x-1.x

  • dpi committed c99652a on 8.x-1.x 
    Issue #2686459 by almaudoh: Remove sms_receipt().

Global method was...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.