WYSIWYG Integration

Mainly small small stuff and a few questions, looks pretty good.

1. +++ b/modules/video_embed_wysiwyg/plugin/plugin.js
   @@ -0,0 +1,133 @@
   +        editor.fire('saveSnapshot');
   +        self.modalSave(editor, values);
   +        editor.fire('saveSnapshot');
   

   We fire the same event both before and after save?

2. +++ b/modules/video_embed_wysiwyg/plugin/plugin.js
   @@ -0,0 +1,133 @@
   +    modalSave: function (editor, values) {
   

   I actually wonder why the event wouldn't be triggered from the modalSave method, in case it was ever saved in another way outside of addCommand.

3. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   + * Drupal\video_embed_wysiwyg\Form\VideoEmbedDialog.
   

   Missing Contains \ at the start.

4. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +      '#default_value' => $this->getUserInput($form_state, 'video_url'),
   ...
   +  protected function getUserInput(FormStateInterface $form_state, $key) {
   +    return isset($form_state->getUserInput()['editor_object'][$key]) ? $form_state->getUserInput()['editor_object'][$key] : '';
   

   Why getUserInput instead of getValue()? From the docs:

   These are raw and unvalidated, so should not be used without a thorough
   * understanding of security implications. In almost all cases, code should
   * use self::getValues() and self::getValue() exclusively.

5. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +   * @param array $settings
   +   * @return \Drupal\Core\Field\FormatterInterface
   +   *   The
   

   Missing docs.

6. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +      'field_definition' => new FieldConfig(['field_name' => 'mock', 'entity_type' => 'mock', 'bundle' => 'mock']),
   

   Pretty nifty that cores apis allow this really.

7. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +    // @todo Render the thumbnail to download it from the remote. Consider
   +    // making the download method public.
   

   Should link to the follow-up.

8. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +      'video_url' => $form_state->getValue('video_url'),
   

   Presuming this goes straight to the plugin to retrieve it, does this have the same level of permissions wrapped around it as normal usage?

9. +++ b/modules/video_embed_wysiwyg/src/Form/VideoEmbedDialog.php
   @@ -0,0 +1,239 @@
   +   * @param \Drupal\Component\Plugin\PluginManagerInterface $formatter_manager
   

   Formatter manager doesn't have its own interface to type-hint against?

10. +++ b/modules/video_embed_wysiwyg/src/Plugin/Filter/VideoEmbedWysiwyg.php
    @@ -0,0 +1,139 @@
    + *   id = "video_embed_wysiswyg",
    

    there is an extra s in wysiwyg

11. +++ b/modules/video_embed_wysiwyg/src/Plugin/Filter/VideoEmbedWysiwyg.php
    @@ -0,0 +1,139 @@
    +   *   Settings to validate.
    +   * @return bool
    +   *   If the required settings are present.
    

    Missing newline.

12. +++ b/modules/video_embed_wysiwyg/src/Tests/EmbedDialogTest.php
    @@ -0,0 +1,134 @@
    +  protected $ajaxAsserts = [];
    +
    +
    

    Double newline.

13. +++ b/modules/video_embed_wysiwyg/src/Tests/FilterTest.php
    @@ -0,0 +1,117 @@
    +    $this->filter->setFilterConfig('video_embed_wysiswyg', ['status' => 1]);
    

    extra s here as well.

14. +++ b/modules/video_embed_wysiwyg/video_embed_wysiwyg.routing.yml
    @@ -0,0 +1,9 @@
    +  requirements:
    +    _entity_access: 'filter_format.use'
    

    There are no extra permissions to use your module?