I have a view table with group.
In some cases the serial increment (field: Global view result counter) is not consistent when the setting of the table has grouping of the field.

Attached the table showing the problem in Global view result counter.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

was.uthm created an issue. See original summary.

eradeepak’s picture

Issue tags: +#ChennaiDrupalGroup
FileSize
761 bytes

Hi Waluyo,
I have created patch file with auto increment in drupal views table for group by field.
Please review it. Hope this will help you.

eradeepak’s picture

waluyo.umam’s picture

Thank you.
Yes, It works. Now the numbering is correct in each group.

eradeepak’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: theme.inc_.patch, failed testing.

eradeepak’s picture

Issue tags: -#ChennaiDrupalGroup +ChennaiDrupalGroup
waluyo.umam’s picture

What's the problem with this patch?
I modified the codes following this patch and it works. Until today not included in the release.

eradeepak’s picture

Status: Needs work » Needs review
zalak.addweb’s picture

Issue tags: +views
waluyo.umam’s picture

Every time updated views, then I have to manually modify the codes to maintain the numbering correct. I hope this patch can be implemented.

Status: Needs review » Needs work

The last submitted patch, 2: theme.inc_.patch, failed testing. View results

TR’s picture

Version: 7.x-3.12 » 7.x-3.x-dev
Issue tags: -counter, -ChennaiDrupalGroup, -views

@was.uthm: The patch failed to apply 2 years ago and still fails to apply. If you would like to see this committed, please re-roll the patch and post it here so the testbot can review it. Then fix any coding standards or other issues identified by the testbot. Code comments and a test case would be nice too ... Once we have a working patch that can apply and pass the tests, then it can be reviewed and potentially committed.

Note that patches must be applied to the most recent development version, so I moved the version to 7.x-3.x.

Back to "Needs work". I also removed the tags. Please see https://www.drupal.org/node/1023102 for guidelines on the proper use of tags. Specifically, you don't need a "views" tag - this is the Views queue. You don't need a "counter" tag, that is just a keyword which is already used in the issue. And "ChennaiDrupalGroup" may have been relevant at one point, but that group hasn't touched this patch in 2 years so it is unlikely they are still working on it - they can add that tag back if they want to resume their participation in this issue.

marksmith’s picture

Patch #2 is breaks the reverse views results counter function.