As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
5 problems (5 errors, 0 warnings)

CommentFileSizeAuthor
#2 monitoring-eslint-error-2.patch1.27 KBNeelanjana Das
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neelanjana Das created an issue. See original summary.

Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
Assigned: Unassigned » Neelanjana Das
FileSize
monitoring-eslint-error-2.patch1.27 KB
Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: monitoring-eslint-error-2.patch, failed testing.

The last submitted patch, 2: monitoring-eslint-error-2.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs work » Closed (duplicate)
Related issues: +#2683375: ESLint check and verify code quality in Monitoring

Please first check the issue queue. There was already an ESLint issue.