Hi,

I ran into this issue, where entity_revision_load() is used to load a taxnomy_term with the revision id then function just return FALSE, even though the revision id DOES exist.

I found that the function checks the entity info to find the what key it's using for the revisionID, and when it fails (i.e. if the entity doesn't support revisioning), it returns false. Even though, technically speaking, that one version of the taxonomy_term is still a revision (even if it's the only revision), and I would expect the function to still return it.

The function description says it would return FALSE "if there is no entity with the given revision id."... which is not the case here.

I will attach a simple patch to add that bit of logic.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

khaled.zaidan created an issue. See original summary.

khaled.zaidan’s picture

khaled.zaidan’s picture

Status: Active » Needs review

Could someone have a look at this please?

Chris Matthews’s picture

Assigned: khaled.zaidan » Unassigned

The 3 year old patch in #2 to entity.module applied cleanly to the latest entity 7.x-1.x-dev and (if still relevant) needs review.