Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Right now the web test tests one set of config. Now that #2676266: There is no option for no markup is upon us, it might be good to create a Kernel test to easily test a lot more variations of config and output quickly.
Proposed resolution
Write more tests!
Remaining tasks
Write more tests!
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#10 | 2683305-config-variations-test-10.patch | 13.9 KB | Sam152 |
#10 | interdiff.txt | 376 bytes | Sam152 |
#2 | 2683305-config-variations-test-2.patch | 13.87 KB | Sam152 |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedAttached is a Kernel test which asserts the field markup under various configurations.
Comment #10
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #11
benjy CreditAttribution: benjy at PreviousNext commentedLooks RTBC to me, just 2 things:
Commented out profile?
phpunit has a assertContains?
Comment #12
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #14
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #15
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedThanks for the review. Profile fixed. The whitespace is amongst the field output, not strictly at the start or end, so both need extraneous whitespace removed everywhere.