Problem/Motivation

JavaScript code must be consistent and free from syntax error and leaking variables and that it can be properly minified.

Proposed resolution

Detect errors and potential problems in JavaScript code with ESLint tool and fix them.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 eslint-mygengo.patch914 bytesCTaPByK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

CTaPByK created an issue. See original summary.

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK at MD Systems GmbH commented
Status: Active » Needs review
FileSize
eslint-mygengo.patch914 bytes

Changes requested by ESLint rules:
-http://eslint.org/docs/rules/eqeqeq
-http://eslint.org/docs/rules/strict
-http://eslint.org/docs/rules/quotes

Status: Needs review » Needs work

The last submitted patch, 2: eslint-mygengo.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

  • miro_dietiker committed 9152f7f on 8.x-1.x authored by CTaPByK 
    Issue #2683281 by CTaPByK: ESLint check and verify code quality in Gengo
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed, thx!

The test fail above indicates that HEAD is broken. I guess it's because it runs against last tmgmt beta2. But this all confuses me about when it got broken...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.