Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
90 problems (89 errors, 1 warnings)
Comments
Comment #2
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedThis patch removed all the errors.
Comment #3
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedComment #5
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedComment #6
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedplease review the patch.
Comment #7
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedComment #8
derjochenmeyer CreditAttribution: derjochenmeyer at forward-media.de commentedThis patch results in a strange indentation of the comments.
Comment #9
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedThe indentation errors and extra lines have been removed and the code has been cleaned up.
Comment #17
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedComment #18
Neelanjana Das CreditAttribution: Neelanjana Das at Melity commentedComment #20
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedFor me, using the attached patches caused the map to not be loaded anymore, because the
var google;
essentially disabled Google Maps.
Can you confirm this?
Attached is a reworked patch version for all js-files. Please review and confirm if all Google Maps based functions still work.
Comment #21
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedComment #23
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedMerged. No local errors. Many warnings left though.
Comment #24
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedSome more fixes as well as restyling the geolocation.js function_names to camelCase
Comment #25
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedClosing this issue again. See #2747251 for progress on JS / eslint side.