Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neelanjana Das created an issue. See original summary.

Neelanjana Das’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: geolocation-eslint-error-2683095-2.patch, failed testing.

Neelanjana Das’s picture

Status: Needs work » Needs review
Neelanjana Das’s picture

please review the patch.

Neelanjana Das’s picture

Title: Geolocation Field » Geolocation Field ESLint Error
derjochenmeyer’s picture

This patch results in a strange indentation of the comments.

Neelanjana Das’s picture

Status: Needs review » Needs work

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

Neelanjana Das’s picture

Neelanjana Das’s picture

Status: Needs work » Needs review

The last submitted patch, 9: geolocation-eslint-error-2683095-9.patch, failed testing.

ChristianAdamski’s picture

For me, using the attached patches caused the map to not be loaded anymore, because the

var google;

essentially disabled Google Maps.
Can you confirm this?

Attached is a reworked patch version for all js-files. Please review and confirm if all Google Maps based functions still work.

ChristianAdamski’s picture

Assigned: Neelanjana Das » Unassigned

  • ChristianAdamski committed e21064b on 8.x-1.x
    Issue #2683095 by Neelanjana Das, ChristianAdamski: Geolocation Field...
ChristianAdamski’s picture

Status: Needs review » Fixed

Merged. No local errors. Many warnings left though.

ChristianAdamski’s picture

Some more fixes as well as restyling the geolocation.js function_names to camelCase

ChristianAdamski’s picture

Status: Needs review » Closed (fixed)

Closing this issue again. See #2747251 for progress on JS / eslint side.