Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 35 problems (35 errors, 35 warnings)
Attached is the full list of errors found by ESLint.
Comment | File | Size | Author |
---|---|---|---|
#2 | plupload_new.patch | 10.58 KB | Swetha Yarla |
Issue fork plupload-2682879
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedHere is the Patch file to fix the js errors in Plupload Module
Comment #3
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #4
budalokko CreditAttribution: budalokko commentedSorry for late review.
Some of the errors were solved in commit 8acc67548b0e2ddafc97e5dcebb7404e8aaf8550 so patch doesn't apply cleanly.
I have tested it on the module before that commit and found the changes to modules/plupload/js/i18n.js break translations. The second part is fine.
I'll prepare another patch against current HEAD.
Also I think ESLint Drupal standards have changed since then, specially those regarding quoting so more changes will be needed if we want no ESLint errors.
Comment #5
budalokko CreditAttribution: budalokko commentedComment #8
budalokko CreditAttribution: budalokko commented