As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 35 problems (35 errors, 35 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#2 plupload_new.patch10.58 KBSwetha Yarla

Issue fork plupload-2682879

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Swetha Yarla created an issue. See original summary.

Swetha Yarla’s picture

Title: Plupload JavaScript clean-up » Plupload ESLint errors
FileSize
10.58 KB

Here is the Patch file to fix the js errors in Plupload Module

Swetha Yarla’s picture

Status: Active » Needs review
budalokko’s picture

Status: Needs review » Needs work

Sorry for late review.

Some of the errors were solved in commit 8acc67548b0e2ddafc97e5dcebb7404e8aaf8550 so patch doesn't apply cleanly.

I have tested it on the module before that commit and found the changes to modules/plupload/js/i18n.js break translations. The second part is fine.

I'll prepare another patch against current HEAD.

Also I think ESLint Drupal standards have changed since then, specially those regarding quoting so more changes will be needed if we want no ESLint errors.

budalokko’s picture

Title: Plupload ESLint errors » Plupload ESLint and other ci errors
Version: 8.x-1.x-dev » 2.1.x-dev

  • budalokko committed c2370f39 on 2.1.x
    Issue #2682879 by budalokko, Swetha Yarla: Improve CI - jslint, phpstan...
budalokko’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.