Problem/Motivation

When migrating users that have an empty value for pictures you get weird files appearing in the files table as shown by the following image:

upgrade test

Proposed resolution

Not sure what is causing this yet.

Remaining tasks

Patch

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#6 interdiff.txt597 bytesbenjy
#6 2681505-6.patch1.82 KBbenjy
#2 2681505-2-FAIL.patch826 bytesbenjy
#2 2681505-2-PASS.patch1.24 KBbenjy
user-picture-FAIL.patch815 bytesbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjy created an issue. See original summary.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2681505-2-PASS.patch1.24 KB
2681505-2-FAIL.patch826 bytes

OK, it was the migration plugin stubbing the file which I don't think we need here because d6_user has d6_user_picture_file as a dependency which will mean that will run first if it exists.

Plus, a new fail patch because the first one was failing even with the fix.

The last submitted patch, user-picture-FAIL.patch, failed testing.

The last submitted patch, 2: 2681505-2-PASS.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2681505-2-FAIL.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs work » Needs review
FileSize
2681505-6.patch1.82 KB
interdiff.txt597 bytes

Opened #2681539: MigrateUpgrade6Test does not migrate files and set the asserted value to 0 as its the UI test that is not migrating any files.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Related issues: +#2681717: Oddly named files (long string of characters) in files dir after migration

Possibly related to #2681717: Oddly named files (long string of characters) in files dir after migration

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Yes, this fixes the problem. I ran a migration, via the UI, without this patch and the arbitrary files were created. Reinstalled D8, applied patch, and reran the same migration, and the files weren't created.

Wasn't familiar with the migration counts until I finished some work on #2500533: Upgrade path for System 7.x and setting it to 0 makes sense.

Therefore, RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Doesn't apply to 8.0.x, so not cherry-picked to there.

  • catch committed c1b5d37 on 8.2.x 
    Issue #2681505 by benjy: Arbitrary files are created when migrating...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.