Scheduler ESLint errors (part 2) [#2681093]

As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 1 problems (1 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

Comment	File	Size	Author
#3	scheduler_vertical_tabs.js_.patch	351 bytes	Swetha Yarla
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 25 pass, 2 fail
#2	output.txt	162 bytes	Swetha Yarla

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 March 2016 at 13:13

Swetha Yarla created an issue. See original summary.

Comment #2

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented 4 March 2016 at 13:15

File	Size
output.txt	162 bytes

Comment #3

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented 4 March 2016 at 13:15

File	Size
scheduler_vertical_tabs.js_.patch	351 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 25 pass, 2 fail

Here is the Patch for fixing js errors in Scheduler.

Comment #4

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented 4 March 2016 at 13:15

Status:

Active

» Needs review

Comment #5

4 March 2016 at 14:18

Status:

Needs review

» Needs work

The last submitted patch, 3: scheduler_vertical_tabs.js_.patch, failed testing.

Comment #6

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented 4 March 2016 at 14:58

Status:

Needs work

» Reviewed & tested by the community

Thanks Swetha. I will commit this.

Interestingly, we already had #2490956: Scheduler ESLint errors back in May 2015. At that time, I think this js file did not contain the Use Strict line. I have an archive from Feb 2015 without it, and an archive from June 2015 with it, so it must have been added after those original errors were fixed.

Jonathan

Comment #7

5 March 2016 at 12:48

jonathan1055 committed 2733254 on 8.x-1.x authored by Swetha Yarla
```
Issue #2681093 by Swetha Yarla: Scheduler ESLint errors
```

Comment #8

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented 5 March 2016 at 12:56

Title:	Scheduler ESLint errors	» Scheduler ESLint errors (part 2)
Status:	Reviewed & tested by the community	» Fixed
Related issues:		+#2490956: Scheduler ESLint errors

Committed. Thank you.

I removed the additional extra blank line at the very end of the file that your patch added. I looked through the JavaScript coding standards you linked, and also the issue about updates for the standards, but did not see anything about requiring a blank line. I checked some core js code files and they did not have it either, so I presumed that was just a mistake in your patch.