As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
4 problems (4 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#3 inline-eslint-2680985-3.patch491 bytesNeelanjana Das
#2 output.txt379 bytesNeelanjana Das
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neelanjana Das created an issue. See original summary.

Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
FileSize
output.txt379 bytes
Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
FileSize
inline-eslint-2680985-3.patch491 bytes
Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
Status: Active » Needs review
Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented
Assigned: Unassigned » Neelanjana Das
Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented

please check the patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Needs work 
+++ b/js/inline_entity_form.js
@@ -4,12 +4,13 @@
  */
-Drupal.behaviors.inlineEntityForm = {
+  Drupal.behaviors.inlineEntityForm = {
   attach: function (context) {
     /*

This breaks the indentation ... this cannot be right :)

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Status: Needs work » Closed (outdated)