As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 1 problems (1 errors, 1 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#5 superfish.patch549 bytesSwetha Yarla
#3 superfish.patch608 bytesSwetha Yarla
#2 output.txt184 bytesSwetha Yarla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Swetha Yarla created an issue. See original summary.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
FileSize
output.txt184 bytes
Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
FileSize
superfish.patch608 bytes

Here is the Patch for fixing Js errors in Superfish Module

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Status: Active » Needs review
Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
FileSize
superfish.patch549 bytes

Here is the new patch for Superfish module generated through git.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented

  • mehrpadin committed 4e0c0de on 8.x-1.x 
    Issue #2680921 by swetha-yarla: ESLint compatibility.

  • mehrpadin committed 5538b95 on 7.x-1.x 
    Issue #2680921 by swetha-yarla: ESLint compatibility.
DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.