As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 3 problems (3 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#4 new_views_php.patch700 bytesSwetha Yarla
#2 views_php.patch1.76 KBMurthyVittala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MurthyVittala created an issue. See original summary.

MurthyVittala’s picture

FileSize
1.76 KB

Here is the patch file to fix the js errors in Views Php module.

MurthyVittala’s picture

Status: Active » Needs review
Swetha Yarla’s picture

FileSize
700 bytes

Here is the new Patch file to fix the js errors in Views php module

rooby’s picture

What is the reason for the patch in #4?

At a glance the patch in #2 looks better, the patch in #4 will leave incorrect indentation.