[D7] Auto Block Scheduler

Automated Review

Found some issues on pareview.sh. Follow link: http://pareview.sh/pareview/httpgitdrupalorgsandboxarulraj2680185git

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not caus] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[/ No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Please provide full info about the module including intstallation, configuration etc.

Code long/complex enough for review

[No: does not follow] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[Suggestion:

1. Implement hook_permission in your code. So that Admin can give permission which user role can manage his newsletter subscriptions.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2694845

Project 2: https://www.drupal.org/node/2680865

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello, I have installed and tested the functionality of the module. It works well and does not cause errors or failures. Your module is quite efficient and and can be useful for my site. Thanks.

@romanblanyar: looks like you forgot to change the status? I this now RTBC after your code review or are there any blockers left?

i have verified and code looks good.

Retested with Pareview.sh, and ran the manual checklist. To my opinion, this module can be shifted to full project.
I do see some spelling issues and one larger function (auto_block_scheduler_list) which might be good to break into smaller parts and/or add some explaining comments.
Do not see blocking things though, so would advice to bring this to full project. Moreover I like the thought behind this one.

manual review:

1. project page: what are the differences to existing projects such as https://www.drupal.org/project/scheduled_block ? Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition.
2. "($block->module ? $block->module : 'No Module'),": all user facing text must run through t() for translation. Please check all your strings.

Otherwise looks good to me.

Thanks for your contribution, Arulraj!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.