Drupal 8 has logo, site name and site logo in a block. Souldn't we remove those hardcoded lines from page.html.twig.

CommentFileSizeAuthor
#2 zircon-remove_site_name_logo-2680849-2.patch1.41 KBzuhair_ak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zuhair_zyxware created an issue. See original summary.

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented
Status: Active » Needs review
FileSize
zircon-remove_site_name_logo-2680849-2.patch1.41 KB

I have removed the hardcoded logo,site name and site slogan from page.html.twig.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commented
Status: Needs review » Closed (works as designed)

These are not hardcoded.

{% if logo %}
-      <a id="logo" href="{{ front_page }}" title="{{ 'Home'|t }}" rel="home">
-        <img src="{{ logo }}" alt="{{ 'Home'|t }}"/>
-      </a>
-    {% endif %}
-
-    {% if site_name or site_slogan %}
-      <div class="name-and-slogan">
-
-        {# Use h1 when the content title is empty #}
-        {% if title %}
-          <strong class="site-name">
-            <a href="{{ front_page }}" title="{{ 'Home'|t }}" rel="home">{{ site_name }}</a>
-          </strong>
-        {% else %}
-          <h1 class="site-name">
-            <a href="{{ front_page }}" title="{{ 'Home'|t }}" rel="home">{{ site_name }}</a>
-          </h1>
-        {% endif %}
 
-        {% if site_slogan %}
-          <div class="site-slogan">{{ site_slogan }}</div>
-        {% endif %}
-      </div>
-   {% endif %}

Variables are printed in this file, as per the site builder add logo site slogan etc, those will print.