From @tim.plunkett's review in #2281691: User interface for migration-based upgrades:

  1. +++ b/core/modules/drupal_upgrade/src/Form/MigrateUpgradeForm.php
    @@ -0,0 +1,1196 @@
    +    // By default, render the form using theme_confirm_form().
    +    if (!isset($form['#theme'])) {
    +      $form['#theme'] = 'confirm_form';
    +    }

    This is an odd way to do this, what other #theme would be here?

Proposed resolution

Refactor the code to reduce complexity.

Remaining tasks

User interface changes

API changes

Data model changes


xjm created an issue. See original summary.

tim.plunkett’s picture

Issue summary: View changes
Status: Active » Closed (duplicate)

This was fixed in #2679016: Misc cleanups