I just noticed that this module's Javascript doesn't pass the attach() context parameter to the jQuery constructor. This will generally only have a small impact, and you already work around potential problems by using .once(), but I still think best practice would be to include it. It will also help avoid problems in some edge cases, and shouldn't in any way negatively affect normal usage.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs review
FileSize
625 bytes

(Trivial) Patch attached.

infojunkie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me

  • drunken monkey committed 18bf66e on 7.x-1.x
    Issue #2679395 by drunken monkey: Fixed jQuery constructor to include...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.