Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I just noticed that this module's Javascript doesn't pass the attach()
context
parameter to the jQuery constructor. This will generally only have a small impact, and you already work around potential problems by using .once()
, but I still think best practice would be to include it. It will also help avoid problems in some edge cases, and shouldn't in any way negatively affect normal usage.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2679395-2--jQuery_context_parameter.patch | 625 bytes | drunken monkey |
Comments
Comment #2
drunken monkey(Trivial) Patch attached.
Comment #3
infojunkieLooks good to me
Comment #5
drunken monkeyGood to hear, thanks for reviewing!
Committed.