1354 eyes!

CommentFileSizeAuthor
#6 2679016.5.patch40.54 KBalexpott
#6 2-5-interdiff.txt8.63 KBalexpott
#2 interdiff.txt30.71 KBtim.plunkett
#2 2679016-mu-2.patch37.74 KBtim.plunkett
docs-standards.patch10.34 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett as a volunteer commented
FileSize
2679016-mu-2.patch37.74 KB
interdiff.txt30.71 KB

This addresses #2281691-116: User interface for migration-based upgrades

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: Docs standards cleanups » Misc cleanups

We shall never speak of this issue scope again. ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Still leaves...

phpcsd ./

FILE: ...drupal8alt.dev/modules/migrate_upgrade/migrate_upgrade.drush.inc
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
 40 | ERROR   | Doc comment short description must be on a single
    |         | line, further text should be a separate paragraph
 60 | WARNING | Line exceeds 80 characters; contains 81 characters
 61 | ERROR   | Doc comment short description must be on a single
    |         | line, further text should be a separate paragraph
----------------------------------------------------------------------


FILE: ...l8alt.dev/modules/migrate_upgrade/src/DrushLogMigrateMessage.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 12 | ERROR | [x] Missing class doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...8alt.dev/modules/migrate_upgrade/src/Form/MigrateUpgradeForm.php
----------------------------------------------------------------------
FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------
   44 | ERROR   | [x] Separate the @todo and @see sections by a blank
      |         |     line.
  599 | ERROR   | [ ] Missing short description in doc comment
  604 | ERROR   | [ ] Missing short description in doc comment
  609 | ERROR   | [ ] Missing short description in doc comment
  614 | ERROR   | [ ] Missing short description in doc comment
  622 | ERROR   | [ ] Missing parameter comment
  623 | ERROR   | [ ] Missing parameter comment
  624 | ERROR   | [ ] Missing parameter comment
  625 | ERROR   | [ ] Missing parameter comment
  866 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
      |         |     found 6
  867 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
      |         |     found 6
  868 | WARNING | [ ] Line exceeds 80 characters; contains 169
      |         |     characters
  868 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
      |         |     found 6
 1088 | WARNING | [ ] Only string literals should be passed to t()
      |         |     where possible
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...al8alt.dev/modules/migrate_upgrade/src/MigrateMessageCapture.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 41 | ERROR | Return comment must be on the next line
----------------------------------------------------------------------


FILE: ...lt.dev/modules/migrate_upgrade/src/MigrateUpgradeDrushRunner.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
 16 | ERROR   | [x] Missing class doc comment
 36 | WARNING | [ ] Line exceeds 80 characters; contains 81
    |         |     characters
 37 | ERROR   | [ ] Doc comment short description must be on a single
    |         |     line, further text should be a separate paragraph
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...l8alt.dev/modules/migrate_upgrade/src/MigrateUpgradeRunBatch.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------
  22 | ERROR   | [x] Missing class doc comment
  63 | ERROR   | [ ] Parameter comment must start with a capital
     |         |     letter
 114 | ERROR   | [x] Expected 1 space after TRY keyword; 2 found
 191 | ERROR   | [x] Concat operator must be surrounded by a single
     |         |     space
 287 | WARNING | [ ] Line exceeds 80 characters; contains 81
     |         |     characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...l8alt.dev/modules/migrate_upgrade/src/MigrationCreationTrait.php
----------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
  28 | ERROR   | [ ] Return comment must be on the next line
  43 | ERROR   | [ ] Return comment must be on the next line
  50 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: FETCH_ASSOC
 107 | WARNING | [ ] Line exceeds 80 characters; contains 93
     |         |     characters
 112 | ERROR   | [ ] Return comment must be on the next line
 147 | ERROR   | [ ] Doc comment short description must be on a
     |         |     single line, further text should be a separate
     |         |     paragraph
 152 | ERROR   | [ ] Return comment must be on the next line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 725ms; Memory: 17.75Mb

The last submitted patch, docs-standards.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2-5-interdiff.txt8.63 KB
2679016.5.patch40.54 KB 
phpcsd ./

FILE: ...drupal8alt.dev/modules/migrate_upgrade/migrate_upgrade.drush.inc
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
 40 | ERROR   | Doc comment short description must be on a single
    |         | line, further text should be a separate paragraph
 60 | WARNING | Line exceeds 80 characters; contains 81 characters
 61 | ERROR   | Doc comment short description must be on a single
    |         | line, further text should be a separate paragraph
----------------------------------------------------------------------


FILE: ...l8alt.dev/modules/migrate_upgrade/src/DrushLogMigrateMessage.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 12 | ERROR | [x] Missing class doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...lt.dev/modules/migrate_upgrade/src/MigrateUpgradeDrushRunner.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
 16 | ERROR   | [x] Missing class doc comment
 36 | WARNING | [ ] Line exceeds 80 characters; contains 81
    |         |     characters
 37 | ERROR   | [ ] Doc comment short description must be on a single
    |         |     line, further text should be a separate paragraph
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 625ms; Memory: 18Mb

Only drush stuff left now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

And the drush stuff is not going in to core.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Form/MigrateUpgradeForm.php
@@ -587,6 +597,65 @@ class MigrateUpgradeForm extends FormBase implements ConfirmFormInterface {
+   * MigrateUpgradeForm constructor.

I will verbify this on commit.

  • xjm committed 9bd1506 on 8.x-1.x 
    Issue #2679016 by alexpott, tim.plunkett, xjm: Misc cleanups
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks!

  • xjm committed 9bd1506 on 8.x-2.x 
    Issue #2679016 by alexpott, tim.plunkett, xjm: Misc cleanups

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.