Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 2 problems (2 errors, 0 warnings)
Attached is the full list of errors found by ESLint.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | menu_attributes.patch | 513 bytes | Swetha Yarla |
| #6 | new_menu_attributes.patch | 6.63 KB | Swetha Yarla |
| #2 | menu_attributes.patch | 3.5 KB | Swetha Yarla |
| output.txt | 265 bytes | Swetha Yarla | |
Comments
Comment #2
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedI found 2 Errors in menu attributes js file which I have fixed in the attached patch.
Comment #3
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #4
joelpittetThanks, setting status because there is a patch. FYI this is a duplicate issue. Though I'm not closing because this one has a patch and better issue summary.
Comment #5
joelpittetThe patch in #2 just deletes a file. @Swetha Yarla could you try again?
Comment #6
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedHere is the new Patch to fix the js errors in Menu attributes Module
Comment #7
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #8
joelpittetSomething is still wrong with the patch, it doesn't apply and it looks to be changing the file name and not relative to the project's root.
Here's some documentation that may help fill in the gaps.
https://www.drupal.org/node/707484
Comment #9
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedThis is the new patch for menu attributes generated through git..
Comment #10
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented