Allow retain time to more then 999 an dunlimit it with -1.

When reviewing, I spotted two tests where you test against a amended (from 999) magic value for "unlimited" as 0 instad of -1. Here are the diffs, followed by what I think the diff should be:

In anonymous_publishing.module:

59c59
<   if ($cl_audodelhours < 999) {
---
>   if ($cl_audodelhours) {

Should be?

59c59
<   if ($cl_audodelhours < 999) {
---
>   if ($cl_audodelhours >= 0) {

In modules/anonymous_publishing_cl.admin.module:

1150c1150
<   $b2 = 999 > $autodelhours ? _anonymous_publishing_email_text('activate', $variables) : '';
---
>   $b2 = $autodelhours ? _anonymous_publishing_email_text('activate', $variables) : '';

Should be?

1150c1150
<   $b2 = 999 > $autodelhours ? _anonymous_publishing_email_text('activate', $variables) : '';
---
>   $b2 = $autodelhours >= 0 ? _anonymous_publishing_email_text('activate', $variables) : '';

I've already commited your patch to the 7.x-1.x branch, but changed those two lines as indicated above. I've also rolled both updates to the "unlimited" variables into a single update.

Please review and either confirm that my changes are correct, or point out what I've misunderstood.

In practice, the point behind if ($cl_audodelhours) { is that any negative value would fail because if (-2) => FALSE

This is not correct. Try the following.

$r = -2 ? 'TRUE' : 'FALSE';
debug($r, 'logical value of -2');

On my computer, it produces:

Debug: logical value of -2:
'TRUE'

Oh.. you must be right ! Just change it to $autodelhours >= 0 then!

I did that 5 hours ago. Commit b9c7868.

Changing status to RTBC.

This is in release 7.x-1.1.

This doesn't seem to be working for me using v7-1.1

I get the following error when trying to configure CL settings (leaving this specific option at the desired default -1):

Error message
Number of hours to retain unverified anonymous posts before auto-deletions removes them: must be a positive integer.

Using 0 doesn't work, either, but I don't WANT a positive integer here (implying that my only option is to have unverified content be automatically deleted at some future point).

Thanks for your report @Glottus. Reopening.

Incidentally, I CAN save the settings by deleting the default provided "-1" and leaving the field blank, but I don't know what effect this will have, nor how to test it, exactly.

This is fixed in the latest snapshot of 7.x-1-x-dev.

Please review.

I am now able to set "-1" as an option for the retention time. Thanks!

Moving to RTBC based on #18.

Fixed in release 7.x-1.2.