Rename Drupal.ajax.WRAPPER_FORMAT in Drupal.Ajax.WRAPPER_FORMAT for documentation and consistency purpose.

From [#10000449-93].

Comments

nod_ created an issue. See original summary.

nod_’s picture

Issue summary: View changes
Wim Leers’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Status: Reviewed & tested by the community » Needs work

The last submitted patch, core-js-ajax-const.patch, failed testing.

nod_’s picture

need reroll because of JSDoc patch

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

zeeshan_khan’s picture

Assigned: Unassigned » zeeshan_khan
zeeshan_khan’s picture

Assigned: zeeshan_khan » Unassigned
Status: Needs work » Needs review
FileSize
780 bytes

Re-rolled patch attached!

Thanks :)

shaktik’s picture

Status: Needs review » Reviewed & tested by the community

looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Needs review

Is this not an API change? Drupal.ajax and Drupal.Ajax are not the same things...

nod_’s picture

It is, but right now WRAPPER_FORMAT can't appear in the documentation because it's tied to the Drupal.ajax function and not the object like it's supposed to. Like this it's also consistent with what's happening in the backend with MainContentViewSubscriber::WRAPPER_FORMAT

See http://read.theodoreb.net/drupal-jsapi/Drupal.html#.ajax compared to http://read.theodoreb.net/drupal-jsapi/Drupal.Ajax.html#.AJAX_REQUEST_PA...

alexpott’s picture

@nod_ okay so do we expect any fallout for contrib from this change - it feels risky but I'm not best placed to quantify that risk.

nod_’s picture

Maybe some modules that do fancy ajax-y things. But since it's hasn't been talked about much (either in blog posts or in the queue) I don't expect problems. The ones that would be using this would be core-aware devs. A change notice would be enough to warn them.

Wim Leers’s picture

#13++

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.