Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 31 problems (31 errors, 0 warnings)
Attached is the full list of errors found by ESLint.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | calendar_overlap.patch | 6.03 KB | Swetha Yarla |
| #6 | calendar_colorpicker.patch | 1.12 KB | Swetha Yarla |
| #3 | output.txt | 2.71 KB | Swetha Yarla |
Comments
Comment #2
dawehnerThis seems to be a better place for it.
Comment #3
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #4
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #5
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #6
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedComment #7
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedI found 31 Errors in calendar js file which I have fixed in the attached patch.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedLooks good. Commited and pushed to 8.x-1.x. Thank you!
Just so you know, the path in the patch file confuses my git so I couldn't easily apply. You might want to look into that for future patches,
Comment #10
Swetha Yarla CreditAttribution: Swetha Yarla at Melity commentedThanks for suggesting the path updates. I would take care of the paths in future commits.