SlickNav unterminated statements cause aggregation to break JavaScript [#2677036]

The SlickNav plugin causes a site's JavaScript to break when CSS/JS aggregation is enabled and using jQuery 1.10. The error message presented is as follows:

Uncaught SyntaxError: Unexpected identifier

After performing some investigation, it was found that SlickNav is missing commas at the end of statements, which throws jQuery "Unterminated statements" errors. When this JavaScript is then aggregated, it breaks.

I will attach a patch for review in a minute.

Comment	File	Size	Author
#4	unterminated_statements-2677036-4.patch	3.99 KB	kala4ek
#4	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error
#2	adminimal_admin_menu-unterminated_statements-2677036-2.patch	3.78 KB	ron_s
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 February 2016 at 12:50

ron_s created an issue. See original summary.

Comment #2

ron_s CreditAttribution: ron_s commented 27 February 2016 at 12:52

Status:

Active

» Needs review

File	Size
adminimal_admin_menu-unterminated_statements-2677036-2.patch	3.78 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Here is a patch for review. Once this has been finalized, I'd recommend asending this to the SlickNav developers so they can make sure to fix the issue in their code. Thanks.