Formatted Tweets view handler needs protocol-relative image URLs

Attached is a patch for this for 7.x-6.x, following the same approach as in the linked issue.

One comment is needed: This strips the protocol from the entire themed output; that will include the links to "retweet" etc., and also any outbound links within the tweet itself. This is not a problem, however, because both the domains twitter.com and t.co return identical content over https.

When it comes to patching 7.x-5.x, it should be noted that this identical patch works for that branch.

Oops. :blush:

It would help if I remembered to include the line that actually makes this patch do anything. The version from #1 was a mere placebo. Try again!

But why did the first patch fail to apply? Anyone see what I did wrong that - it runs fine through "patch" on my system.

OK. I'm being slow this evening. It failed testing because I was on the wrong branch. Doh.

Here's one for the 7.x-6.x branch. Should pass tests.

Doesn't this patch remove all "http:" strings from the tweet, because it runs str_replace on the whole themed output, and this is not image specific code? I don't think it is the intended result.

Yes. It does. But no, it's not a problem. See my comment when I first submitted a patch:

One comment is needed: This strips the protocol from the entire themed output; that will include the links to "retweet" etc., and also any outbound links within the tweet itself. This is not a problem, however, because both the domains twitter.com and t.co return identical content over https.

Perhaps I should elaborate. Twitter turn any linked content within a tweet into a short-link on the t.co domain. t.co returns identical content whether you access a link over https or http. If someone puts an http link into a tweet, you can still access the t.co short URL over https, and Twitter's URL shortener will resolve it to the original http link (I've just checked that). For this reason, if you actually browse twitter.com in a web browser, all the t.co links are now showing as https.

The only other links you'll get are on the twitter.com domain - links to retweet / a person's twitter homepage / etc. All of those also resolve fine over http and https.

So if every linked resource in a tweet was linked in a protocol-relative syntax, that will never pose a problem, and is the direction that Twitter themselves seem to be moving in for their own site.

I'll set this back to Needs Review. But if I've missed a problem with this, please explain in a bit more detail why we can't have every tweet resource served over https.